search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.42k stars 960 forks source link

Add project setting ci_pipeline_variables_minimum_override_role #2057

Closed vindvaki closed 1 week ago

vindvaki commented 2 weeks ago

This is a companion setting to restrict_user_defined_variables, allowing more granular control over who can set job variables and pipeline variables in a project. Currently, the setting restrict_user_defined_variables acts as a toggle for the restriction set by ci_pipeline_variables_minimum_override_role, but it is likely that restrict_user_defined_variable will be deprecated in favor of just ci_pipeline_variables_minimum_override_role in the future.

See https://docs.gitlab.com/ee/ci/variables/#restrict-who-can-override-variables

vindvaki commented 2 weeks ago

@timofurrer @RicePatrick looks like you are the new maintainers? Could either of you please review? Thanks!

RicePatrick commented 2 weeks ago

@vindvaki - Yep, I'll probably get to it tomorrow; thanks for the ping!

RicePatrick commented 1 week ago

Approved the GitHub workflows, and one last nitpick then this LGTM!

timofurrer commented 1 week ago

@vindvaki @RicePatrick I'm going to merge here. Thanks Hordur! I assume you need a release?