xapi-project / nbd

Ocaml NBD library
https://xapi-project.github.io/nbd/
Other
13 stars 16 forks source link

Server does not send EINVAL for unrecognized command flags #149

Open gaborigloi opened 5 years ago

gaborigloi commented 5 years ago

It's partly because of #139 - we do not even parse the command flags. To fix this, we'd have to fix #139 to correctly parse the command flags, and the return EINVAL if we receive any unsupported ones.

This email says that well-behaved servers should respond with einval to unrecognised flags: https://lists.debian.org/nbd/2019/03/msg00004.html