search

xapi-project / nbd

Ocaml NBD library
https://xapi-project.github.io/nbd/
Other
14 stars 16 forks source link

ci: use a single workflow #164

Closed psafont closed 1 year ago

psafont commented 1 year ago

Because publishing docs was done in its own workflow, the last ci change missed it and made the code fail to build, because xs-opam was not ready for this. This would have been avoided if it had been built using the standard opam repository.

To make sure this failure doesn't happen again, integrate building a publishing the docs in the existing workflow.

Gate only the publishing because we want to avoid repetition; and building docs is pretty fast

Signed-off-by: Pau Ruiz Safont pau.safont@citrix.com

coveralls commented 1 year ago

Coverage Status

Coverage decreased (-0.2%) to 64.791% when pulling 0c1a2fafa71ec70d127074eb54e04708187a8a6e on psafont:docfix into aa1bfc5eb58c1defd89cd96bb98f7b6a72fadf42 on xapi-project:master.

psafont commented 1 year ago

Any way to test this, or merge and see?

The current workflow tests that the docs are being built, the only thing that's merge and see is whether the gate works correctly.

I have to limit the upload step to a single run as well, currently it would be uploaded twice. Github workflows is quite bad at defining a graph of tasks, unfortunately