search

xapi-project / sm

Xapi Project storage managers
GNU Lesser General Public License v2.1
21 stars 91 forks source link

ISCSI reconnection when not necessary #702

Open Wescoeur opened 1 month ago

Wescoeur commented 1 month ago

Hello,

We have noticed bad behavior for several months because of this commit: https://github.com/xcp-ng/sm/commit/d28dcc1341166ed4839dbea8ef6d1a24e981f461

In practice the commit that we revert is useful in the case where ISCSI connections are no longer valid, but sometimes even without any config change or bad connections, a disconnect/connect is launched preventing the correct use of the SR. This means that it can interrupt backup tasks, for example.

Wouldn't this piece of code be a little too violent to restart the ISCSI service while the SR is still functional? Wouldn't the code be a little too sensitive to a particular trigger, when there is no reason to restart the service?

Thanks!

MarkSymsCtx commented 1 month ago

The code should not restart the iSCSI service while the SR is functional, the only expected outcome is to establish additional iSCSI sessions which could not be made when the SR was attached (e.g. if a path is down at startup) so that full multipath resilience is provided. If you have logs showing that the iSCSI service is restated or that existing live sessions are impacted by this code please attach them here.