search

xapi-project / vagrant-xenserver

A Vagrant provider for XenServer
MIT License
120 stars 31 forks source link

Support MAC Address Network Parameter #29

Closed jroweboy closed 8 years ago

jroweboy commented 8 years ago

Vagrant allows the Vagrantfile to specify a MAC address as a parameter in networking configuration and this passes that information on to XenServer.

(See http://stackoverflow.com/a/12604643/745719 for an example of this parameter)

Outstanding question: This PR doesn't actually handle cases where the user doesn't put a delimiter in the MAC address such as ':' like the stackoverflow answer says to do. In my experience, Xen didn't set the MAC unless it was colon seperated. Should I add a little check to add in delimiters if the user leaves them out?

jonludlam commented 8 years ago

I think this is fine for now. There's a chance I might change how the plugin works - I'd like it to create actual XenServer templates corresponding to the box files, in which case the template will likely have some VIFs that might need to be fixed up with the right MAC after it's cloned - but likewise it'll have to fix the bridges too. I've not quite decided how it's going to look, so in the interim I'll merge this PR. Thanks!