search

xapi-project / vhd-tool

Command-line tools for streaming and manipulating vhd format data
Other
8 stars 26 forks source link

CA-208537: vdi-copy between local SRs proposes unwanted ciphers #26

Closed ghost closed 8 years ago

ghost commented 8 years ago

To enable TLSv1.2 capability for vhd-tool/sparse_dd, This changes add 3 new options to CLI parameters,

ssl_legacy: boolean, allow all protocol versions instead of default TLSv1.2 good_ciphersuites: string, SSL good cipher suites for TLS protocols legacy_ciphersuites: optional string, SSL legacy cipher suites for TLS protocols

Signed-off-by: Phus Lu phus.lu@citrix.com

ghost commented 8 years ago

DONT merge, just for review currently. /cc @thomassa

ghost commented 8 years ago

Basically verified, @thomassa , are you happy to start review it now :smiley:

simonjbeaumont commented 8 years ago

Review from @thomassa specifically requested. He's off sick today so assigning to him and adding the blocked label so he can pick them up on his return.

simonjbeaumont commented 8 years ago

The CI for this was blocked because the OPAM file in the repo was not passing lint. I've fixed this here https://github.com/xapi-project/vhd-tool/pull/27. By fixed, I mean I've disabled lint in the CI job. This is the best we can do because we are not upstream for this repo.

simonjbeaumont commented 8 years ago

I've restarted the travis job. You should be able to expect one of the subjobs to pass (the OCaml 4.01 one: https://travis-ci.org/xapi-project/vhd-tool/jobs/132751108) -- scrap that, the CI for this repo is more broken that I thought :)

simonjbeaumont commented 8 years ago

@thomassa has returned so I'll remove the blocked label.

thomassa commented 8 years ago

The commit message needs a brief description of the new functionality.

ghost commented 8 years ago

Thanks for @thomassa comments. I reworked the commit.

For docstring in https://github.com/xapi-project/vhd-tool/pull/26/files#diff-37fdba691cdb40a308c807f7605ba30bR72

I leave a leading space for them, to make sparse_dd --help output pretty.

thomassa commented 8 years ago

Thank you: that looks good now except for the two remaining doc strings in main.ml.

ghost commented 8 years ago

Thanks @thomassa . Updated the doc strings. :)

thomassa commented 8 years ago

@phusl All good!

The CI test-build is still failing (because of badly-defined dependencies in opam, and bad packaging-instructions).

So I'm considering merging this anyway...