CA-280242: Open destination VDI O_DIRECT (as well as source).

xapi-project / vhd-tool

Command-line tools for streaming and manipulating vhd format data

Other

8 stars 26 forks source link

CA-280242: Open destination VDI O_DIRECT (as well as source). #49

Closed jonludlam closed 6 years ago

jonludlam commented 6 years ago

Without O_DIRECT we weren't getting IO errors propagated from the sendfile(2) call (not even on close). This was causing us not to notice when copying VDIs to full thinly-provisioned SRs.

Signed-off-by: Jon Ludlam jonathan.ludlam@citrix.com

jonludlam commented 6 years ago

@gaborigloi - use_unbuffered is definitely set by the time we use it: we're using the same function to open the source VDI, and that was already opened O_DIRECT before this change.

jonludlam commented 6 years ago

OK, alll squashed and commit msg updated.