xapi-project / vhd-tool

Command-line tools for streaming and manipulating vhd format data
Other
8 stars 26 forks source link

impl: Strip leading slash from filename if prefix is supplied #9

Closed euanh closed 10 years ago

euanh commented 10 years ago

If prefix is supplied but does not include a trailing slash, then the filename will have a leading slash which will cause int_of_string to fail when trying to interpret the filename as sequence number later.

Signed-off-by: Euan Harris euan.harris@citrix.com

djs55 commented 10 years ago

Could you also make a PR against the upstream version? There are a few xapi-isms in the xapi-project fork, but this looks more like a bug fix we should put everywhere!

euanh commented 10 years ago

Pull request for upstream is: https://github.com/djs55/vhd-tool/pull/13

djs55 commented 10 years ago

Thanks, merged!

On Wed, Apr 9, 2014 at 10:14 AM, Euan Harris notifications@github.comwrote:

Pull request for upstream is: djs55#13https://github.com/djs55/vhd-tool/pull/13

Reply to this email directly or view it on GitHubhttps://github.com/xapi-project/vhd-tool/pull/9#issuecomment-39983471 .

Dave Scott