search

xapi-project / xapi-nbd

Expose XenServer disks conveniently over NBD
Other
4 stars 11 forks source link

CA-298461 use local session for cleanups #35

Closed lindig closed 6 years ago

lindig commented 6 years ago

To avoid races during shutdown, cleanup operations should use local sessions rather than the client session.

Signed-off-by: Christian Lindig christian.lindig@citrix.com

edwintorok commented 6 years ago

Would this unplug/destroy need the same treatment with local sessions? https://github.com/xapi-project/xapi-nbd/blob/a22a42f5439888673e2d61feb959b7db43b3e45b/src/cleanup.ml#L119 Also just noticed a potential problem with two uses of Lwt_main.run concurrently unrelated to this PR: https://github.com/xapi-project/xapi-nbd/issues/36