xapi-project / xapi-storage-script

A xapi storage adapter that calls out to scripts, one script per operation
Other
6 stars 16 forks source link

CP-26574: Ported build from oasis to jbuilder. #53

Closed kc284 closed 6 years ago

mseri commented 6 years ago

Note, this PR depends on https://github.com/xapi-project/message-switch/pull/37 being merged and on xs-opam being updated with the changes

mseri commented 6 years ago

It would be nice to also add a jbuild file to build the example.

UPDATE: I have looked at the code, it's only interpreted as a script, nothing is needed

mseri commented 6 years ago

Does this https://github.com/xapi-project/xapi-storage-script/blob/3d4d8cee4e2bb5fb5b9430488b9f5e41b73eaf7c/main.ml#L926 need a Message_switch_something now?

kc284 commented 6 years ago

It should, I'm in the process of updating this PR.