search

xapi-project / xapi-storage-script

A xapi storage adapter that calls out to scripts, one script per operation
Other
6 stars 16 forks source link

Report SR_PROBE capability #60

Closed gaborigloi closed 6 years ago

gaborigloi commented 6 years ago

This is okay to do now, because SR.probe works for SMAPIv3 SRs too: we try to reconstruct the same XML structure that is returned by SMAPIv1 SRs.

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

gaborigloi commented 6 years ago

I've listed the SM object of GFS2 and it contained the SR_PROBE capability & feature indeed, and the probe quicktest also found the GFS2 SR and ran.

gaborigloi commented 6 years ago

This is probably fine, but it's best to discuss it before merging. Since we're planning to make SR.probe_ext work on every SR that has the SR_PROBE capability, we probably shouldn't introduce a new capability for probe_ext.

edwintorok commented 6 years ago

RIght so probe_ext would be handled purely on the XAPI side, and we know that if a SMAPIv3 plugin reports probe capability we would get the enhanced probe_ext and regular probe at same time. And for SMAPIv1 XAPI could translate probe into probe_ext if possible.