search

xapi-project / xapi-storage-script

A xapi storage adapter that calls out to scripts, one script per operation
Other
6 stars 16 forks source link

CP-31450: Add domid to Datapath.attach #85

Closed BenSimsCitrix closed 5 years ago

BenSimsCitrix commented 5 years ago

We now honour the existing API of Datapath.attach by passing the domid of vm that the vbd is being attached to.

This will enable a qemu process per vm.

Signed-off-by: ben sims ben.sims@citrix.com

BenSimsCitrix commented 5 years ago

The iso as whole builds successfuly on private/bensi/CP-31450/12

I observe in the logs that the domid passed to Datapath.attach is now correct and consistent with the output of xl list.

I'd like to test this more thoroughly, so im keen to hear you ideas.

The following pull requests need to be simultaneous otherwise the build will break

https://github.com/xapi-project/xcp-idl/pull/278 https://github.com/xapi-project/xen-api/pull/3910 https://github.com/xapi-project/xapi-storage-script/pull/85 https://github.com/xapi-project/xenopsd/pull/644

BenSimsCitrix commented 5 years ago

This has passed

Storage BST Job ID 110188 DiffHostCrossPoolSXM Job ID 2594732 (Old version Lima) DiffHostCrossPoolSXM Job ID 2594733 (Old version Dundee)

Latest changes have built

BenSimsCitrix commented 5 years ago

This is ready for merge unless there are more review issues