search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

Replace python example code with minimal functional implementation. #105

Closed MarkSymsCtx closed 4 years ago

MarkSymsCtx commented 4 years ago

Signed-off-by: Mark Syms mark.syms@citrix.com

MarkSymsCtx commented 4 years ago

Looks good to me but it's quite a bit of code.

It's about the smallest amount that can actually be functional, unlike the removed example which didn't actually do anything other than respond to the requests. This example is good enough to install and run VMs on albeit with some limitations.

lindig commented 4 years ago

Can we merge this?

edwintorok commented 4 years ago

Looks good, one minor comment about SR_METADATA

lindig commented 4 years ago

Can we merge this?