search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

Enable automated PEP-8 checking #56

Closed robertbreker closed 8 years ago

simonjbeaumont commented 8 years ago

I'd be keen to see this become part of the travis tests... (take a look at http://github.com/xenserver/planex 's travis file)

robertbreker commented 8 years ago

Adding a pep8 verification to the travis test is certainly a good idea - I'll add flake8 to avoid regressions going forward.

robertbreker commented 8 years ago

Done. This was already worth it - I've also amended the manual pep8 fixes, as they still weren't compliant. Did a push -f as that's probably easier to review for the few lines in the (manual pep8 fixes) patch.

djs55 commented 8 years ago

Ooh, pep8 sounds like a good idea.

Hope all is well!

On Sat, Sep 26, 2015 at 6:23 PM, Robert Breker notifications@github.com wrote:

Done. This was already worth it - I've also amended the manual pep8 fixes, as they still weren't compliant. Did a push -f as that's probably easier to review for the few lines in the (manual pep8 fixes) patch.

— Reply to this email directly or view it on GitHub https://github.com/xapi-project/xapi-storage/pull/56#issuecomment-143471703 .

Dave Scott