search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

fix opam dep conflict with rpc #65

Closed edwintorok closed 6 years ago

edwintorok commented 6 years ago

rpc requires cow > 2.0.0 to build (fails with 1.4.0), and xapi-storage requires cow < 2.0.0. But obviously we are able to build both using the .spec files, so fix the opam dependency to allow co-installation with rpc.

After this change I was able to pin and install both xapi and xapi-storage in the same opam switch.

edwintorok commented 6 years ago

Thanks, the build error looks unrelated (flake8 lint complaining about our python, we should probably fix that though sometime).

gaborigloi commented 6 years ago

@edwintorok Just realized that the spec file of this repo only seems to build the stuff in the ocaml/ subdirectory, so maybe this dependency constraint is actually needed by the code in the generator/ dir?

edwintorok commented 6 years ago

I've run make and the generator worked, I think xapi-storage got updated to support the new cow library, but the constraint was forgotten. Looks like <2.0.0 had to be added because we still relied on camlp4, we only use ppx now here so we're good.