search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

CP-26711: Ported xapi-storage to jbuilder. #69

Closed kc284 closed 6 years ago

kc284 commented 6 years ago

Note this will need a spec file change.

kc284 commented 6 years ago

With regards to the restructuring of the generator code, another way to do it is split and move the executables to the folders where they generate stuff, i.e. doc\gen, ocaml\examples, ocaml\lib, python or even python\xapi\storage\api; that solution would make the paths simpler, although it would mean we would have generator code across the repo. I don't have a strong opinion on this.

edwintorok commented 6 years ago

Note that there were some changes to xapi-storage on feature/REQ477/master branch, including fixing Travis, so if Travis fails here you might want to cherry-pick some commits from the feature branch (or submit the jbuilder change to the feature branch).

edwintorok commented 6 years ago

Looks like you might need to cherry-pick this commit too to fix travis: https://github.com/xapi-project/xapi-storage/commit/26d12b81cf0dbc700994c2d2acd0376f342bda85

edwintorok commented 6 years ago

Do you need any other PRs other than xapi-storage-script? if not we can remove the do-not-merge label after you cherry-picked the python flake8 fix commit.

lindig commented 6 years ago

This has don't merge - is this still correct?

kc284 commented 6 years ago

All the relevant PRs are in place, I'm only waiting for a successful build on the feature branch (I had to rebase once or twice) and then we can merge.