xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

[WiP] probe changes #74

Closed edwintorok closed 6 years ago

edwintorok commented 6 years ago

These are the probe changes on top of the feature/REQ477/smapiv3.x branch. Once those changes are merged I'll rebase this.

Has to be merged together with: https://github.com/xapi-project/xcp-idl/pull/208 https://github.com/xapi-project/xen-api/pull/3477 https://github.com/xapi-project/xapi-storage-script/pull/58

gaborigloi commented 6 years ago

@edwintorok Can we rebase now, I think the changes are in?

edwintorok commented 6 years ago

Yes extra_info is meant for XenCenter for example to display additional info, but you wouldn't want to send those to SR.create, or SR.attach so we wouldn't want to merge it with device_config.

MarkSymsCtx commented 6 years ago

extra _info is used during probe to hint back to the user, for instance an iSCSI portal might export multiple IQNs but if the user hasn't supplied the IQN they want to use yet then the extra info can contain the list of possible IQNs so that one can be selected. Similarly LUNs if multiple LUNs can be seen with the details and SCSI ID to select the right one

gaborigloi commented 6 years ago

Another thing that's unclear to me is that what information those strings convey for the SR health type. This isn't documented at the moment.

edwintorok commented 6 years ago

Closing, will reopen when probe branch is complete.