search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

generator/html: fix ocaml code example syntax highlight #78

Closed gaborigloi closed 6 years ago

gaborigloi commented 6 years ago

Caml2html outputs a string containing html tags, which were escaped by Cow, and therefore the HTML source of the syntax-highlighted OCaml code was displayed as plain text.

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

mseri commented 6 years ago

Do we need caml2html or we can use some newer way? This code does not look much different than usign Cow directly

gaborigloi commented 6 years ago

I'm not sure, I don't know of any other OCaml highlighters. But I've checked and it seems that caml2html cannot output a node type usable by Cow.

mseri commented 6 years ago

Most things use pygmentize I think

gaborigloi commented 6 years ago

I think only reason for using it is that caml2html is written in OCaml. I tried using it as a library too but got an annoying warning.

mseri commented 6 years ago

I understand that, but if even pandoc offloads it to pygmentize, it is maybe worth a look

gaborigloi commented 6 years ago

Hmm ok, that's convincing indeed.