search

xapi-project / xapi-storage

Experimental new storage interface for xapi
https://xapi-project.github.io/xapi-storage/
9 stars 19 forks source link

review probe API changes to feature/REQ477/master #79

Closed edwintorok closed 6 years ago

edwintorok commented 6 years ago

Part of a series of PR, main PR here: https://github.com/xapi-project/xcp-idl/pull/217

Changes API of SMAPIv3 SR.create and SR.attach to take a device-config map instead of a JSON serialized into a string and called 'uri'. Probe will return the device-config needed for SR.create/SR.attach.

Backwards compatibility with existing SMAPIv3 plugins is handled in the xapi-storage-script PR: xapi-storage always declares the latest APIs and xapi-storage-script takes care of translating the requests/responses in a backward compatible way.

gaborigloi commented 6 years ago

I'll port these changes to the https://github.com/gaborigloi/xapi-storage/tree/sxm branch of xapi-storage, which is based on ocaml-rpc once this is merged. So we should try to merge that branch soon to minimise the divergence.

edwintorok commented 6 years ago

We should merge the sxm branch after feature freeze and master branching.