Especially in their handling of unicode string, with .format being better.
So, convert the logging in call to use this to avoid getting incorrect errors in failure conditions, otherwise an unhelpful error of the form UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 28: ordinal not in range(128) is produced, instead of what actually went wrong in the process call.
Generally tidy up some python style issues as well.
Especially in their handling of unicode string, with .format being better.
So, convert the logging in call to use this to avoid getting incorrect errors in failure conditions, otherwise an unhelpful error of the form
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 28: ordinal not in range(128)
is produced, instead of what actually went wrong in the process call.Generally tidy up some python style issues as well.
Signed-off-by: Mark Syms mark.syms@citrix.com