search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

CP-22405: Log message for config file not existing #102

Closed Frezzle closed 7 years ago

Frezzle commented 7 years ago

Removes spurious backtrace occurring on first boot because config file /var/lib/xcp/networkd.db does not exist yet.

Signed-off-by: Frederico Mazzone frederico.mazzone@citrix.com

Frezzle commented 7 years ago

Before the change, the log would show this on first-boot:

May 16 08:42:21 localhost xcp-networkd: [error|localhost|0 |startup|network_config] Error while trying to read networkd configuration: Unix.Unix_error(Unix.ENOENT, "open", "/var/lib/xcp/networkd.db")#012Raised by primitive operation at file "lib/unixext.ml", line 120, characters 10-39#012Called from file "lib/unixext.ml", line 170, characters 47-73#012Called from file "lib/network_config.ml", line 91, characters 20-59

After the change, we do not have a stacktrace for the case of the file not existing:

May 18 18:57:27 localhost xcp-networkd: [error|dt53|0 |startup|network_config] Cannot read networkd configuration file /var/lib/xcp/networkd.db because it does not exist.

I tested this by temporarily removing the file before reading it, to simulate the first-boot scenario.