search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

CP-23093: Implement toggle of IGMP snooping on xcp-networkd #107

Closed fillzero closed 7 years ago

fillzero commented 7 years ago

Signed-off-by: Liang Dai liang.dai1@citrix.com

fillzero commented 7 years ago

@robhoes -- Would you please review this PR? Based on the multicast feature design, we need to implement a toggle of IGMP Snooping.

We also need to add a field igmp_snooping for type bridge_config_t and a new RPC message named set_ovs_igmp_snooping in repo xcp-idl. Please help to create a new branch for development.

fillzero commented 7 years ago

This PR depends on https://github.com/xapi-project/xcp-idl/pull/164

robhoes commented 7 years ago

This is fine now, but we can't merge it without the matching change in xcp-idl, and we can't merge that without a change to xen-api, for which there is no PR yet.

fillzero commented 7 years ago

Thanks @robhoes . Regarding the xen-api change, @YarsinCitrix will send PR later.

Also copy @huizh to be aware.

robhoes commented 7 years ago

@fillzero @huizh For the xen-api change, I would suggest to first have a PR to just fill in the new field in the network_config with a default value, so that these changes can go in quickly. We can have a separate PR for the API changes, for which we are still discussing the design.

robhoes commented 7 years ago

I'll close this for now. When the xen-api patch is ready, I'll reopen and merge this PR.

huizh commented 7 years ago

Hi @robhoes, thanks for the review and the suggestion. Very helpful. Will follow up your suggestion to raise a XenAPI PR so that to get this and https://github.com/xapi-project/xcp-idl/pull/164 merged.