search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

CP-26352 Port xcp-networkd from Camlp4 to PPX #128

Closed krizex closed 6 years ago

krizex commented 6 years ago
  1. update implementation per interface changes
  2. for interface implementation, move labeled parameter and optional parameter to positional parameter and remove useless tail unit parameter

Signed-off-by: Yang Qian yang.qian@citrix.com

This PR should goes in with https://github.com/xapi-project/xcp-idl/pull/189

This change is Reviewable

minishrink commented 6 years ago

Could you name this PR to something like "CP-26352: Port xcp-networkd from Camlp4 to PPX", so it's relevant to the repo you've modified? That way we can tell all your PRs apart by title.

krizex commented 6 years ago

I really don't like that we are removing all the named parameters here. is there any way to re-enable these?

@mseri Yes, two options:

  1. ocamlrpc implements labeled parameter support
  2. keep the interface as before and add wrapper function so that we can bind the interface implementation to the wrapper function, and call the actual implementation (which keep the labeled parameter) inside.
krizex commented 6 years ago

@minishrink Thanks, I will update the title and commit message. Wrt to the optional comments you mentioned, I'd like to keep the code as is because that's not in the scope of this pull request. I'd like to keep this PR as small as possible. We could apply the minor changes in the future.

krizex commented 6 years ago

Update with some minor changes.

krizex commented 6 years ago

Ring3 BVT passed in job 79965 Ring3 BST passed job 79962 Network regression passed job 80071 except infrastructure issues of bond cases on BOURNE04, I have spoke it to Rama and got confirmed, the ticket has been assigned to him.

mseri commented 6 years ago

I am going to do a manual merge to master and close the PR to ppx_network