add DNS servers when either IPv4 or IPv6 is configured and not using …

xapi-project / xcp-networkd

The XCP networking daemon

Other

14 stars 42 forks source link

add DNS servers when either IPv4 or IPv6 is configured and not using … #181

Closed benjamreis closed 3 years ago

benjamreis commented 3 years ago

…DHCP

Signed-off-by: BenjiReis benjamin.reis@vates.fr

This fix is taken from another PR: https://github.com/xapi-project/xcp-networkd/pull/156.

benjamreis commented 3 years ago

IDK what caused the CI to fail. Build works fine on my side.

psafont commented 3 years ago

CI failes becuase the script used for testing has changed how the container name is generated, and has generated a name that doesn't exist in dockerhub. I'll look into this.

benjamreis commented 3 years ago

Thx!

robhoes commented 3 years ago

@psafont, do we still need a CI fix?

psafont commented 3 years ago

It should be fixed now, but we can't trigger rebuilds. The branch builds and passes the test on my machine for what is worth.

To retrigger a travis run I think a git amend --no-edit && git push -f would work.

benjamreis commented 3 years ago

Will do

benjamreis commented 3 years ago

Success! \o/