search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

Remove usages of List.hd #186

Closed psafont closed 3 years ago

psafont commented 3 years ago

List.hd can raise exceptions in locations where they are not expected. Quite a few deals with string splits, these can be worked around to not use lists at all. Others need to raise a semantically-correct error to properly debug the issue.

Signed-off-by: Pau Ruiz Safont pau.safont@citrix.com

psafont commented 3 years ago

I've replaced the travis workflow with a github actions workflow:, which is successful:

https://github.com/psafont/xcp-networkd/runs/1927777307?check_suite_focus=true https://github.com/psafont/xcp-networkd/runs/1927868461?check_suite_focus=true

psafont commented 3 years ago

https://github.com/xapi-project/xcp-networkd/issues/23#issuecomment-27680200 😀

robhoes commented 3 years ago

@psafont it got worse: now I hate all List.hd, not just the unguarded ones :)