search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

Start xcp-networkd with priority 14 #58

Closed robhoes closed 8 years ago

robhoes commented 8 years ago

This ensures that xcp-networkd is started after forkexecd, which has a start priority of 13 (since 97cc4745 in forkexecd.git).

Signed-off-by: Rob Hoes rob.hoes@citrix.com

johnelse commented 8 years ago

Is this actually the script that gets installed on a XenServer? Or is it this one?

robhoes commented 8 years ago

Ehm... probably the other one, so I'll raise another PR :) Might as well merge this one too, to keep them in sync?

thomassa commented 8 years ago

Is there any way we could have just one of them? If not, we should probably have a comment in each as a reminder about the other one.

robhoes commented 8 years ago

It would be great to have just one of them. I don't know why there is a separate one in xen-api-libs-specs... Perhaps @jonludlam knows why?

johnelse commented 8 years ago

I suspect this one just got put here for safe keeping when we split up xen-api - I'm pretty sure the one in xen-api-libs-specs is the only one that ends up in the product.

euanh commented 8 years ago

@johnelse is right, the spec file in xen-api-libs-specs refers to the xcp-networkd-init in that repository.

robhoes commented 8 years ago

So what is the right thing to do: keep and update the script in this repo, or remove it?

johnelse commented 8 years ago

I'm all for removing this one, assuming it's the same as the one in xen-api-libs-specs.

robhoes commented 8 years ago

Funny enough, even xen-api-libs-specs has two versions of the init script... (see xenserver/xen-api-libs-specs#131).

johnelse commented 8 years ago

Of course :wink:

robhoes commented 8 years ago

I'll close this PR, and open a new one to remove the init script.