search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

CP-15312: Remove dhcp6 exception from toolstack startup #65

Closed koushikcgit closed 8 years ago

koushikcgit commented 8 years ago

dhclient handles all ipv6 related configurations and hence dhcp6 is not required

Signed-off-by: Koushik Chakravarty koushik.chakravarty@citrix.com

koushikcgit commented 8 years ago

Previous work: https://github.com/xapi-project/xcp-networkd/pull/64

koushikcgit commented 8 years ago

Adding @robhoes as reviewer

robhoes commented 8 years ago

@koushikcgit The Dhclient module has some functions to to check whether a dhclient process is already running, and doing the right thing based on that. Please have a look at the IPv4 case, and do something similar. This will make the high-level function idempotent and should avoid unnecessary errors in the logs.

robhoes commented 8 years ago

xen-git is again complaining about Wrong type NilClass. Not allowed! :(

jonludlam commented 8 years ago

I think this might have been because gandalf was full. I have performed a log purge (including a console log from an errant mirage VM that was spewing rubbish into /tmp) so it might work now.

koushikcgit commented 8 years ago

@robhoes: Updated

robhoes commented 8 years ago

:shipit: after the :icecream: