search

xapi-project / xcp-networkd

The XCP networking daemon
Other
14 stars 42 forks source link

CA-219257: Make enic driver workaround configurable. #88

Closed sharady closed 8 years ago

sharady commented 8 years ago

From xcp-networkd.conf file we can configure enic-workaround-until-version="x.x.x.x" to the version till enic driver workaround will be applied or set the version to an empty string for not applying the workaround.

Signed-off-by: Sharad Yadav sharad.yadav@citrix.com

lindig commented 8 years ago

I don't have a strong opinion about this but would use a different name for the flag: enic_workaround_enabled=true/false. It is shorter and shares with the other flag the same enic prefix.

robhoes commented 8 years ago

The enic_driver_version config option should have a name that more clearly indicates what it is for, e.g. enic-workaround-until-version. We can also combine the two options into one, and say that the workaround is disabled if enic-workaround-until-version is the empty string.