xapi-project / xen-api

The Xapi Project's XenAPI Server
http://xenproject.org/developers/teams/xapi.html
Other
346 stars 283 forks source link

Incorrect inflight metrics #5412

Open benjamreis opened 7 months ago

benjamreis commented 7 months ago

Hello!

A user on our forum reported that the inflight metrics returned by XAPI were incorrect, and it appears the metrics is being accumulated instead of simply updated with the new value according to @psafont.

What should we do to fix this behavior?

Thanks!

psafont commented 7 months ago

The solution would be to stop adding current values with the previous ones for gauges in the accumulate function linked in the forum.

You can see which values are used for gauges in the ds_make function: https://github.com/xapi-project/xen-api/blob/master/ocaml/xcp-rrdd/bin/rrdp-iostat/rrdp_iostat.ml#L783