search

xapi-project / xen-api

The Xapi Project's XenAPI Server
http://xenproject.org/developers/teams/xapi.html
Other
344 stars 283 forks source link

Hugo docs: Add dark mode support, theme variant selector and print #5702

Closed bernhardkaindl closed 1 month ago

bernhardkaindl commented 1 month ago

Hello @robhoes and @contificate,

Thanks everyone for all the reviews and tips for #5698!

In https://github.com/xapi-project/xen-api/pull/5698#issuecomment-2175713287 there was some doubt (or maybe just misunderstanding) on the second commit of #5698 for publishing a preview of the docs on the clone repo's GitHub pages (will only be published if the GitHub pages are configured to be published from GitHub actions, not from the gh-pages branch).

In any case, the two commits of #5698 are no dependent on each other, so this submits only the first commits of it for review.

Thanks for the hints on fixing or working around these issues!

I cannot incorporate them in this PR at the moment because I'll be on PTO until Monday.

But if you merge (or otherwise approve - does not have to be now - the) enabling the selection of the theme variants (independent on if you include the auto switch to dark mode by default using the "auto" variant), we can make the fixes for those locations over time.

You can also close this PR if you like to have either the dark mode or print view issues fixed before enabling the automatic dark mode, all of that is fine of course.

I only opened these PRs because I saw the possibility to make these features of the theme available.

I'll (tentatively) close #5698 and to focus on this PR for now.

edwintorok commented 1 month ago

This PR would be fine, but I don't see why the pytype workflow failed on it in the CI.

bernhardkaindl commented 1 month ago

This PR would be fine, but I don't see why the pytype workflow failed on it in the CI.

Thanks, the pytype error must have been caused by a wrong ref as opened initially against master, but was on top of feature/py3 and I changed the target branch afterwards.

I reopened the commit based and targeted on master in #5703 now.