Remark:
Same #5702 (closed), but for master (because it had nothing to do with py3 and had an unrelated CI failure)
Thanks everyone for all the reviews and tips for #5698!
In https://github.com/xapi-project/xen-api/pull/5698#issuecomment-2175713287 there was some doubt (or maybe just misunderstanding) on the second commit of #5698 for publishing a preview of the docs on the clone repo's GitHub pages (will only be published if the GitHub pages are configured to be published from GitHub actions, not from the gh-pages branch).
In any case, the two commits of #5698 are no dependent on each other, so this submits only the first commits of it for review.
Thanks for the hints on fixing or working around these issues!
I cannot incorporate them in this PR at the moment because I'll be on PTO until Monday.
But if you merge (or otherwise approve - does not have to be now - the) enabling the selection of the theme variants (independent on if you include the auto switch to dark mode by default using the "auto" variant), we can make the fixes for those locations over time.
You can also close this PR if you like to have either the dark mode or print view issues fixed before enabling the automatic dark mode, all of that is fine of course.
I only opened these PRs because I saw the possibility to make these features of the theme available.
I'll (tentatively) close #5698 and to focus on this PR for now.
Remark: Same #5702 (closed), but for master (because it had nothing to do with py3 and had an unrelated CI failure)
Thanks everyone for all the reviews and tips for #5698!
In https://github.com/xapi-project/xen-api/pull/5698#issuecomment-2175713287 there was some doubt (or maybe just misunderstanding) on the second commit of #5698 for publishing a preview of the docs on the clone repo's GitHub pages (will only be published if the GitHub pages are configured to be published from GitHub actions, not from the
gh-pagesbranch).In any case, the two commits of #5698 are no dependent on each other, so this submits only the first commits of it for review.
Thanks for the hints on fixing or working around these issues!
I cannot incorporate them in this PR at the moment because I'll be on PTO until Monday.
But if you merge (or otherwise approve - does not have to be now - the) enabling the selection of the theme variants (independent on if you include the auto switch to dark mode by default using the "auto" variant), we can make the fixes for those locations over time.
You can also close this PR if you like to have either the dark mode or print view issues fixed before enabling the automatic dark mode, all of that is fine of course.
I only opened these PRs because I saw the possibility to make these features of the theme available.
I'll (tentatively) close #5698 and to focus on this PR for now.