search

xapi-project / xen-api

The Xapi Project's XenAPI Server
http://xenproject.org/developers/teams/xapi.html
Other
344 stars 283 forks source link

Make `cluster-stack-version` show up in the CLI #5711

Closed Vincent-lau closed 3 weeks ago

Vincent-lau commented 1 month ago

This makes cluster-stack-version show up as a field of the cluster object in cli

Vincent-lau commented 1 month ago

This makes cluster-stack-version show up as a field of the cluster object in cli

We also have

[root@lcy2-dt110 ~]# xe host-param-get param-name=software-version uuid=c1517689-49cd-4088-9f20-149678beb526 
product_version: 8.4.0; product_version_text: 8; product_version_text_short: 8; platform_name: XCP; platform_version: 3.4.0; product_brand: XenServer; build_number: stream; git_id: 0.41.g036d8331c; hostname: localhost; date: 20240606T14:09:08Z; dbv: 2024.0229; is_preview_release: false; xapi: 24.15; xapi_build: 24.15.0.41.g036d8331c; xen: 4.17.4-4; linux: 4.19.0+1; xencenter_min: 2.21; xencenter_max: 2.21; network_backend: openvswitch; db_schema: 5.778

Ok, what does this have to do with my PR? Or are you just pointing out something interesting?

lindig commented 4 weeks ago

If we are looking for a way to report versions, extending xe host-param-get param-name=software-version would be a good way. Why do we need different methods?

Vincent-lau commented 4 weeks ago

Ah, that's because it is not just for reporting versions, it also controls which version of the cluster-stack (corosync) will be started, and used internally in all sorts of places. I think extending the software-version would work just fine as well, but that would require parsing that string in order to find out the cluster-stack-version?

That said, using software-version would probably work just as well, and makes them all in one place, but it is probably too late to change this design....

lindig commented 4 weeks ago

We could create a ticket to report the version there in addition? Maybe for @last-genius