search

xapi-project / xen-api

The Xapi Project's XenAPI Server
http://xenproject.org/developers/teams/xapi.html
Other
346 stars 283 forks source link

CA-390277: Fix cross-pool migration from CH8.2CU1 to XS8 when using xe #5717

Closed psafont closed 2 months ago

psafont commented 3 months ago

Host records have changed between CH8.2CU1 and XS8, this means that the records produced from an new host cannot be serialized by this code. Instead of making the remote host filter records, now the client tries to fetch the correct reference, and if it can't, fetches all references and fetches fields to find it.

Records from Networks, PBDs and SRs are still used.

I've manually verified that the cross-pool migrations now work

psafont commented 3 months ago

I've reworked the approach to be more minimalistic in change. Now records for Networks, PBDs and SRs are still used, but this allows for fewer roundtrips, and cross-pool migrations to XS8 hosts work.

Vincent-lau commented 3 months ago

so this and #5773 are two different PRs, why is there two?

psafont commented 3 months ago

On master, we're adding a new call. This calls needs to be available on the remote server. This means that if we add this call here for Yangtze, cross-pool migration will only be compatible with new enough hosts. We want the migration to be compatible with as many versions of xapi as possible

psafont commented 3 months ago

Converting to draft to avoid premature merging, we need to run some automated tests on this