Open edwintorok opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
turn off transitive deps in dune, so we are more explicit about our build dependencies (this makes it more obvious if you want a certain module to not link with something)
I'm surprised this doesn't cause problems in xs-opam, I've tried turning them off, but the xen-built xenctrl findlib libraries have a different name from the dummy xenctrl's (xenmmap
and xenctrl.xenmmap
in particular), making it impossible to build using an opam switch. Have you tested these changes in a developer opam switch?
but the xen-built xenctrl findlib libraries have a different name from the dummy xenctrl's (
xenmmap
andxenctrl.xenmmap
in particular),
There is an explicit dependency on xenmmap
now for dbgring
. And the koji
/opam
inconsistency has been fixed long ago by https://github.com/xapi-project/xenctrl/pull/7.
I haven't tried building this in the xs-opam CI, but it builds in koji
, in this CI and locally in an xs-opam based 4.14.1 opam switch.
Whats new: