search

xapi-project / xen-api

The Xapi Project's XenAPI Server
http://xenproject.org/developers/teams/xapi.html
Other
346 stars 283 forks source link

CP-28369: Remove `Unixext.daemonize` #6026

Closed last-genius closed 5 days ago

last-genius commented 5 days ago

Last usage of Unixext.daemonize was in cdrommon, drop it and move the daemon to be fully handled by systemd (instead of type=forking).

cdrommon service is only started by storage scripts, and I'm not sure if it's tested at all, but these changes pass BST+BVT.

psafont commented 5 days ago

This should remove maybe_daemonize and daemonize from ocaml/xapi-idl/lib/xcp_service.ml as well (and it's uses).

There's also a daemon parameter which should be removed as well in the file

last-genius commented 5 days ago

This should remove maybe_daemonize and daemonize from ocaml/xapi-idl/lib/xcp_service.ml as well (and it's uses).

Done.

Incomprehensible python test errors, not sure of the cause. Will do another round of BST+BVT, but the changes should have just made the defaults explicit.

psafont commented 5 days ago

The upload coverage failed because of:

 Error: Bad Gateway (502)

I think we're forced to re-run it, or the merge will be blocked on it