xapi-project / xenopsd

XCP toolstack domain manager
Other
15 stars 68 forks source link

CA-351823 UPD-678 [@sexp.option] fix #746

Closed lippirk closed 3 years ago

robhoes commented 3 years ago

So this problem does not exist on master, because we use a newer version of sexplib?

edwintorok commented 3 years ago

Do we use @sexp.option anywhere else on Stockholm?

lippirk commented 3 years ago

So this problem does not exist on master, because we use a newer version of sexplib?

Yes - the problem also doesn't exist on havana, because we're still using sexp_option there: https://github.com/xapi-project/xenopsd/blob/0.17-lcm/lib/suspend_image.ml

lippirk commented 3 years ago

Do we use @sexp.option anywhere else on Stockholm?

Probably not, since doing a search on github yields only this instance: https://github.com/search?q=org%3Axapi-project+%5B%40sexp.option%5D&type=code