.desktop should be a valid D-Bus well-known name

xapp-project / gnome-online-accounts-gtk

A GTK Frontend for GNOME Online Accounts

GNU General Public License v3.0

15 stars 2 forks source link

.desktop should be a valid D-Bus well-known name #8

Closed doppelhelix closed 5 months ago

doppelhelix commented 6 months ago

Since the .desktop file is not named org.x.GnomeOnlineAccountsGtk.desktop, some taskbars like waybar or the Gnome dash don't show the correct icon for the running program.

Reference: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#file-naming

I can make a pull request but Im not sure about which way to go. Just edit the meson.build? or should gnome-online-accounts-gtk.desktop.in.in be renamed to org.x.GnomeOnlineAccountsGtk.desktop.in.in too?

clefebvre commented 6 months ago

should it be org.gnome.OnlineAccountsGtk.desktop? We don't have a DNS so it's hard to come up with a reverse DNS..

GNOME dash shouldn't really matter since GNOME has its own UI for GOA in its control center. In fact we should probably hide GOA-GTK in GNOME so it doesn't duplicate the functionality there.

Why isn't waybar supporting the initial version of the spec? Many apps use simple filenames for their desktop file.