search

xaptum / ecdaa

A C implementation of elliptic-curve-based Direct Anonymous Attestation (DAA) signatures. Created to support the Xaptum Edge Network Fabric, an IoT Network Solution.
https://www.xaptum.com
Apache License 2.0
45 stars 8 forks source link

cmake: Install non-templatized header files. #125

Closed zanebeckwith closed 5 years ago

zanebeckwith commented 5 years ago

This fixes a reversion from commit 65c45de.

When we removed non-templated header files from being processed by the expander, that also meant they weren't getting copied into the build directory. During building, this was OK because we also added the source directory to the include directories. However, because we install only the include directories under the build directory, this meant the non-templated (but part of the public API) header files weren't installed.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 83.864% when pulling 538382399be3257120a1b4c01e4c18527114febd on zanebeckwith:install-all-headers into ed9465415054c8ef1f3f4f816a9695e708b19a44 on xaptum:master.

drbild commented 5 years ago

Also, good catch! How did xtt ever build for us with these missing?

zanebeckwith commented 5 years ago

Yea, I like that CMake install approach much better. I wasn't aware of that option, thanks!

I also added a small test script for Travis-CI to test whether our installation can be used by a downstream test program. I hope this will help avoid future situations like this!