Cannot compile tools on 32-bit arch

xaptum / ecdaa

A C implementation of elliptic-curve-based Direct Anonymous Attestation (DAA) signatures. Created to support the Xaptum Edge Network Fabric, an IoT Network Solution.

https://www.xaptum.com

Apache License 2.0

45 stars 8 forks source link

Cannot compile tools on 32-bit arch #127

Closed drbild closed 5 years ago

drbild commented 5 years ago

The tools/verify_ZZZ.c file hardcodes the usage of ACML functions and types with the BIG_256_56 prefix. However, that prefix is only valid on 64 bit architectures. On 32 bit, the correct prefix is BIG_256_28.

I just won't build the tools for the router card, right now. They aren't needed there.

Possibly related, hardcoding the 256 seems suspicious as well. Is that correct for all the curves that ECDAA supports (like BLS383)?

zanebeckwith commented 5 years ago

No, this is a simple oversight. Those should be templated with a _XXX rather than a _256_56, just like it does with the curve type (via _ZZZ). Sorry

drbild commented 5 years ago

👍 I'll try your fix right now.