Closed zanebeckwith closed 4 years ago
I just pushed two new commits, fixing two issues I found after opening this PR:
.travis/install-tpm2-tss
script wasn't actually building the specified version, it was actually checking out the master
ecdaa-config.cmake
file still had a find_dependency
for xaptum-tpm
libtss2
libraryAlso, I'll update the documentation (which currently says to use a utility in xaptum-tpm
to prepare a TPM for testing) after merging this
Also, I'll update the documentation (which currently says to use a utility in
xaptum-tpm
to prepare a TPM for testing) after merging this
Since this PR hadn't been merged, I just pushed these changes to this branch, instead.
It's just an update to the documentation:
tpm2-tss
, not xaptum-tpm
as a dependencyecdaa
utility (which already existed, I assume for this purpose, but I just didn't update the README) for preparing a physical TPM for testing, rather than a utility from xaptum-tpm
This PR transitions this project from using
xaptum-tpm
for the "TSS" (TPM Software Stack), to the officialtpm2-software/tpm2-tss
(this is the implementation available via APT on Debian-based systems, for example).TEMPORARY: The build is still failing, because Valgrind Memcheck is complaining about some uninitialized memory usage in theUPDATE: The uninitialized memory usage warning from Memcheck is happening in the tpm2-tss library's "mssim" TCTI (this is the TCTI that communicates with the software simulator we run). I checked that it doesn't arise when running against a device TPM, so it appears to be just concerning the mssim TCTI (and, since the device TCTI is OK, any production usage of this library should be OK). And, our code does properly call the "Init" function for the mssim TCTI, so this appears to be a problem in their library. I silenced the warning by explicitly zero-initializing the TCTI buffer in our tests. I'll try to track down the issue and open a PR in their repo if I can, or at least open an issue there.tpm2-tss
library. I'll track that down (either figure out if it's our fault, or silence the warnings). But I wanted to get your feedback on the CMake stuffThis PR:
libtss2-sys
library, but the tests also use either thelibtss2-tcti-device
orlibtss2-tcti-mssim
depending on whether they communicate with the TPM via a device file or via a TCP socket, i.e. with a simulator)install-xaptum-tpm
script with ainstall-tpm2-tss
onelibtss2-dev
package available, it is very old (pre1.x.x
version), and Ubuntu 18.04 mysteriously doesn't have anylibtss2
packagecppcheck
was complaining about two easy-to-fix minor issues, so this PR includes those fixes, too