Clarify usage of sign and verify for unlinkable signatures

xaptum / ecdaa

A C implementation of elliptic-curve-based Direct Anonymous Attestation (DAA) signatures. Created to support the Xaptum Edge Network Fabric, an IoT Network Solution.

https://www.xaptum.com

Apache License 2.0

45 stars 8 forks source link

Clarify usage of sign and verify for unlinkable signatures #136

Closed zanebeckwith closed 4 years ago

zanebeckwith commented 4 years ago

This PR:

Clarifies (well, actually states) the documentation for the sign and verify functions when used with "unlinkable" signatures, i.e. not using a basename
- In such cases, both basename == NULL and basename_len == 0 must be true
Makes the checks for those conditions in the code a little more explicit
- Previously, this check was done in only one sub-function, and so was a little implicit
Adds tests for this functionality

This was spurred by Issue #135

coveralls commented 4 years ago

Coverage increased (+0.2%) to 80.136% when pulling fe60d8c87694fcfaf78bcbd784ac8dcb014ae314 on zanebeckwith/unlinkable-usability into 6ed9c2ad62f17c60b6ffce33dde42df20340be70 on master.