search

xaptum / ecdaa

A C implementation of elliptic-curve-based Direct Anonymous Attestation (DAA) signatures. Created to support the Xaptum Edge Network Fabric, an IoT Network Solution.
https://www.xaptum.com
Apache License 2.0
45 stars 8 forks source link

Fix bls383 #64

Closed zanebeckwith closed 6 years ago

zanebeckwith commented 6 years ago

Tests using BLS383 were failing, when verifying signatures created using a basename.

The root of the issue is that the ecp_BLS383_fromhash function needs to multiply the generated point by the cofactor of the curve group (in order to put the point in the proper subgroup of the full curve group).

For the other curves, this didn't arise, because their cofactors are 1. BLS383, though, has a rather large cofactor.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.8%) to 96.177% when pulling 6a818ecbbc501dc0dbadb312ba5374d2271850bd on zanebeckwith:fix-bls383 into 9db9629605aae7e74f173ac2d8cd0d4e8bb53f45 on xaptum:master.