search

xaptum / xaptum-buildroot

External Buildroot tree for Xaptum hardware
GNU General Public License v2.0
0 stars 0 forks source link

Copied uboot patches from xaprw/xaprc boards #10

Closed peterhaijen closed 5 years ago

peterhaijen commented 6 years ago

Maybe use a shared patches directory for this?

drbild commented 6 years ago

@peterhaijen Are all of these patches needed for the Xplained board? U-boot already ships with a device tree and config for that board.

Yes, a shared patches directory could be good here. Want to update this commit to introduce a shared patches directory, rather than copying the patches?

peterhaijen commented 6 years ago

I don't know if these are required. I'm not working on uboot, I'm working on pass-through mode and then secure mode, and a host driver. I am still using whatever uboot came pre-installed on my board.

Perhaps then it's better to discard this commit for now. If and when it turns out in the future that uboot for the Xplained board needs patches, we can look into that.

I am expecting new hardware sometime this month, so chances are that no-one will be using the Xplained board anymore in a couple of weeks, anyway.

drbild commented 6 years ago

Sounds good. I'll leave this PR open for now. Once you have new hardware, we can decide if we want to update the Xplained configs or just remove them entirely.

peterhaijen commented 6 years ago

Hi @drbild there is a build dependency on these patches, i.e., without these patches applied, the sama5d2 config won't even make successfully.

drbild commented 5 years ago

Hmm, see my comment on #8 .