xargsgrep / PortKnocker

Port Knocker Android Client
Apache License 2.0
31 stars 10 forks source link

Request ipv6 #3

Closed MedVed007 closed 7 years ago

MedVed007 commented 8 years ago

Hi will it be possible to allow using ipv6 address for host. Working name with AAA records, but not possible to enter ipv6 address. Thank you

TDFKAOlli commented 7 years ago

Hi MedVed007,

the hostname does already support IPv6 addresses - in my understanding-, the only fix needed is allowing to enter colon in the hostname filter:

@@ -26,7 +26,7 @@ public class HostnameInputFilter implements InputFilter
         for (int i = start; i < end; i++)
         {
             char c = source.charAt(i);
-            if (!Character.isLetterOrDigit(c) && c != '.' && c != '-') return "";
+            if (!Character.isLetterOrDigit(c) && c != '.' && c != '-' && c != ':') return "";
         }
         return null;
     }

When I try with example IPv6 address I do get "Network unreachable" which indicates in principle the address is taken. I just don't have a proper IPv6 setup. You have to try yourself with that fix.

Cheers, TDFKAOlli

MedVed007 commented 7 years ago

Hi, no problem to test it, just in which version it will be available in play? Thanks

TDFKAOlli commented 7 years ago

As of Google-Android security all applications upload to play are signed with a private key. So only xargsgrep could upload a new version to Google playstore. Not sure if he is still active and could do this minor fix and upload. Or you build it yourself...

xargsgrep commented 7 years ago

merged and published to play store. thanks for the fix.