xarial / xcad

Framework for developing CAD applications for SOLIDWORKS, including add-ins, stand-alone applications, macro features, property manager pages, etc.
https://xcad.net
MIT License
126 stars 25 forks source link

event PropertyValueChangedDelegate ValueChanged not work well #97

Closed Brent-bai closed 1 year ago

Brent-bai commented 1 year ago

Event PropertyValueChangedDelegate ValueChanged not work well when I use the solidworks customize properties tab. ValueChanged method does not really calculate the difference between the old and new value. I hope maybe the method store the old value, so I can add a function to calculate the value does chaged or no.

artem1t commented 1 year ago

Please try the dev build (or I will publish beta soon). I think the issue is the SW event for properties was not operating properly for some time (e.g. only raised when API changes property, not the user), so xCAD has a complex workaround where it checks when the Properties dialog is open and closed and calculates the differences which seem like has a bug in it. It seems like SW has finally fixed the issue with the original event so the dev build reverts back to the actual sw event which should fix this problem. Please let me know what version of SW do you use and I will double check this.

Brent-bai commented 1 year ago

hi, Visual studio 2022, solidworks2019, Xcad.solidworks 0.8.0-beta.4627

artem1t commented 1 year ago

The underlying SW event only started to work properly in SW 2020, I am afraid (you can check with the ProeptyChanged event from the IPartDoc). I checked in SW 2019 and it does not fire, ut fires in the later versions.