search

xarray-contrib / cf-xarray

an accessor for xarray objects that interprets CF attributes
https://cf-xarray.readthedocs.io/
Apache License 2.0
157 stars 39 forks source link

Pooch is missing from xf_xarray dependencies #440

Closed Zeitsperre closed 1 year ago

Zeitsperre commented 1 year ago

https://github.com/xarray-contrib/cf-xarray/blob/9383257195293c9294519af0133ae6102b324511/cf_xarray/utils.py#L85

Ran into an issue on some projects due to the new pooch requirement:

   ...
   File "/home/runner/work/RavenPy/RavenPy/.tox/py38/lib/python3.8/site-packages/cf_xarray/accessor.py", line 2048, in add_canonical_attributes
    info, table, aliases = parse_cf_standard_name_table(source)
  File "/home/runner/work/RavenPy/RavenPy/.tox/py38/lib/python3.8/site-packages/cf_xarray/utils.py", line 85, in parse_cf_standard_name_table
    import pooch
ModuleNotFoundError: No module named 'pooch'

I know it's a very small change, but I think pooch should be bundled with cf_xarray.

dcherian commented 1 year ago

I chose to put it as an optional dependency in pyproject.toml because not everyone needs it.

Zeitsperre commented 1 year ago

Ah, I didn't see that it was added to an installation recipe. My bad!

Best!