xarray-contrib / cf-xarray

an accessor for xarray objects that interprets CF attributes
https://cf-xarray.readthedocs.io/
Apache License 2.0
152 stars 39 forks source link

repo-review round 2 #485

Closed dcherian closed 7 months ago

dcherian commented 7 months ago

xref #468

codecov[bot] commented 7 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2a1e4e1) 83.12% compared to head (39b7431) 83.68%.

Files Patch % Lines
cf_xarray/accessor.py 69.44% 11 Missing :warning:
cf_xarray/units.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #485 +/- ## ========================================== + Coverage 83.12% 83.68% +0.55% ========================================== Files 14 14 Lines 2679 2697 +18 Branches 189 198 +9 ========================================== + Hits 2227 2257 +30 + Misses 402 390 -12 Partials 50 50 ``` | [Flag](https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib) | Coverage Δ | | |---|---|---| | [mypy](https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib) | `44.66% <52.85%> (+1.84%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib) | `94.04% <76.78%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.