search

xarray-contrib / cf-xarray

an accessor for xarray objects that interprets CF attributes
https://cf-xarray.readthedocs.io/
Apache License 2.0
152 stars 39 forks source link

Add larger bit depth for displaying flag_masks #492

Closed mps01060 closed 5 months ago

mps01060 commented 5 months ago

I would like to add larger bit depth support for displaying the flags / flag_masks as in #491 . Thank you for considering this.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c2f2540) 93.93% compared to head (cc814e1) 93.94%.

Files Patch % Lines
cf_xarray/formatting.py 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #492 +/- ## ======================================= Coverage 93.93% 93.94% ======================================= Files 12 12 Lines 1699 1717 +18 ======================================= + Hits 1596 1613 +17 - Misses 103 104 +1 ``` | [Flag](https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/492/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/492/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib) | `93.94% <96.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xarray-contrib#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcherian commented 5 months ago

Thanks, this LGTM!