Not passing `interp` kwargs to `DataArray.interp`

xarray-contrib / pint-xarray

Interface for using pint with xarray, providing convenience accessors

https://pint-xarray.readthedocs.io/en/latest/

Apache License 2.0

99 stars 12 forks source link

Not passing `interp` kwargs to `DataArray.interp` #267

Open martijnvandermarel opened 2 weeks ago

martijnvandermarel commented 2 weeks ago

https://github.com/xarray-contrib/pint-xarray/blob/ca4e282dda63c5b3ea39b9743fbf7165506b8e72/pint_xarray/accessors.py#L754

From the documentation it seems the kwargs argument is meant to be passed unmodified to xarray's DataArray.interp method. However from the line above it doesn't seem to do that.

The same goes for the assume_sorted argument by the way.

keewis commented 2 weeks ago

Thanks for the report, @martijnvandermarel.

This looks like a copy/paste error and is definitely not intentional (and Dataset seems to also be affected). I'd be happy to take a PR that fixes that, if you're up for it.