Pass `kwargs` and `assume_sorted` to xarray `interp` for both `DataArray` and `Dataset`

xarray-contrib / pint-xarray

Interface for using pint with xarray, providing convenience accessors

https://pint-xarray.readthedocs.io/en/latest/

Apache License 2.0

105 stars 12 forks source link

Pass `kwargs` and `assume_sorted` to xarray `interp` for both `DataArray` and `Dataset` #270

Closed martijnvandermarel closed 3 months ago

martijnvandermarel commented 3 months ago

[x] Closes https://github.com/xarray-contrib/pint-xarray/issues/267
[x] Tests added
[x] Passes pre-commit run --all-files
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

martijnvandermarel commented 3 months ago

@keewis Please let me know if tests and whats-new changes are needed for this PR.

keewis commented 3 months ago

sorry for the late reply, and thanks for the PR!

Yes, tests would be great so we don't regress. That can be very simple ones like comparing the results of .pint.interp and .interp if no unit conversion is necessary.

whats-new changes

yes, please.

martijnvandermarel commented 3 months ago

Thanks @keewis , I adapted the tests based on your comments.

keewis commented 3 months ago

once again sorry for being somewhat slow. Looks good to me now!

martijnvandermarel commented 2 months ago

No problem! @keewis any chance this gets released soon?